Implement get_serialize_properties() handler #2419
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decouple handling of __sleep() from remaining serialization logic completely. In particular, create an explicit HT with the properties that are to be serialized. To compensate, remove the previously existing names HT and perform duplicate property handling on the fly. A side benefit of doing it this way is that duplicate properties will be detected even if they only clash after name mangling.
The signature is intentionally the same as for get_debug_info(), as these can commonly share an implementation.
|
I remember asking about something similar few years ago and there was some opposition so might be good idea to discuss it again maybe... https://www.mail-archive.com/[email protected]/msg66293.html |
|
@nikic can we get a status update here please ? |
|
This has been superseded by #3579. The first commit here, which cleans up __sleep handling, might still be applicable, but it seems to have minor behavior changes, so it's safer to just leave it alone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately it looks like we can't use this in ext/date, as ext/date also supports
__set_stateand relies onget_properties()for that. I'm wondering whether we oughtn't be respecting__sleepforvar_exportas well, in which case it could useget_serialize_properties()too.